From ae1446ed62f2d7de3c47b3ef7e2015bae26be6e4 Mon Sep 17 00:00:00 2001 From: pacien Date: Fri, 17 Feb 2023 23:01:37 +0100 Subject: changelog: mention EPUB support for v2.2 --- changelog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/changelog.md b/changelog.md index ea2385e..45cb6e7 100644 --- a/changelog.md +++ b/changelog.md @@ -13,6 +13,7 @@ release. Releases are tracked and referred to using git tags. - New features: - viewer: add `CTRL-K` keyboard shortcut for quick search. - viewer: added a button to download the current item. + - viewer: add support for EPUB files - Bug fixes: - compiler: fix detection of dimensions of EXIF-rotated pictures. Rebuild the gallery with `--rebuild-all` to purge erroneous cached data. -- cgit v1.2.3 From 64f3ee483b2148c773a404ca296836f7259a9670 Mon Sep 17 00:00:00 2001 From: pacien Date: Fri, 24 Feb 2023 22:08:49 +0100 Subject: mre: move minimal reproducible examples to develop branch Instead of having them in separate orphan branches. --- mre/mre_only_subtraction_shows_others/berlin.md | 0 .../berlin.md.yaml | 2 + mre/mre_only_subtraction_shows_others/gallery.yaml | 2 + mre/mre_only_subtraction_shows_others/paris.md | 0 .../paris.md.yaml | 2 + mre/mre_only_subtraction_shows_others/readme.md | 20 ++++ mre/mre_similar_tags_caps/gallery.yaml | 2 + mre/mre_similar_tags_caps/readme.md | 49 ++++++++++ mre/mre_similar_tags_caps/test.md | 0 mre/mre_similar_tags_caps/test.md.yaml | 2 + mre/mre_similar_tags_caps/test_with_caps.md | 0 mre/mre_similar_tags_caps/test_with_caps.md.yaml | 2 + .../baseball_bat.md | 0 .../baseball_bat.md.yaml | 2 + .../cricket_bat.md | 0 .../cricket_bat.md.yaml | 2 + .../gallery.yaml | 6 ++ .../readme.md | 105 +++++++++++++++++++++ .../winged_bat.md | 0 .../winged_bat.md.yaml | 2 + 20 files changed, 198 insertions(+) create mode 100644 mre/mre_only_subtraction_shows_others/berlin.md create mode 100644 mre/mre_only_subtraction_shows_others/berlin.md.yaml create mode 100644 mre/mre_only_subtraction_shows_others/gallery.yaml create mode 100644 mre/mre_only_subtraction_shows_others/paris.md create mode 100644 mre/mre_only_subtraction_shows_others/paris.md.yaml create mode 100644 mre/mre_only_subtraction_shows_others/readme.md create mode 100644 mre/mre_similar_tags_caps/gallery.yaml create mode 100644 mre/mre_similar_tags_caps/readme.md create mode 100644 mre/mre_similar_tags_caps/test.md create mode 100644 mre/mre_similar_tags_caps/test.md.yaml create mode 100644 mre/mre_similar_tags_caps/test_with_caps.md create mode 100644 mre/mre_similar_tags_caps/test_with_caps.md.yaml create mode 100644 mre/mre_tags_in_multiple_categories_not_correctly_filtered/baseball_bat.md create mode 100644 mre/mre_tags_in_multiple_categories_not_correctly_filtered/baseball_bat.md.yaml create mode 100644 mre/mre_tags_in_multiple_categories_not_correctly_filtered/cricket_bat.md create mode 100644 mre/mre_tags_in_multiple_categories_not_correctly_filtered/cricket_bat.md.yaml create mode 100644 mre/mre_tags_in_multiple_categories_not_correctly_filtered/gallery.yaml create mode 100644 mre/mre_tags_in_multiple_categories_not_correctly_filtered/readme.md create mode 100644 mre/mre_tags_in_multiple_categories_not_correctly_filtered/winged_bat.md create mode 100644 mre/mre_tags_in_multiple_categories_not_correctly_filtered/winged_bat.md.yaml diff --git a/mre/mre_only_subtraction_shows_others/berlin.md b/mre/mre_only_subtraction_shows_others/berlin.md new file mode 100644 index 0000000..e69de29 diff --git a/mre/mre_only_subtraction_shows_others/berlin.md.yaml b/mre/mre_only_subtraction_shows_others/berlin.md.yaml new file mode 100644 index 0000000..628c1f4 --- /dev/null +++ b/mre/mre_only_subtraction_shows_others/berlin.md.yaml @@ -0,0 +1,2 @@ +tags: +- germany diff --git a/mre/mre_only_subtraction_shows_others/gallery.yaml b/mre/mre_only_subtraction_shows_others/gallery.yaml new file mode 100644 index 0000000..8cbc96b --- /dev/null +++ b/mre/mre_only_subtraction_shows_others/gallery.yaml @@ -0,0 +1,2 @@ +includedFiles: +- '*.md' diff --git a/mre/mre_only_subtraction_shows_others/paris.md b/mre/mre_only_subtraction_shows_others/paris.md new file mode 100644 index 0000000..e69de29 diff --git a/mre/mre_only_subtraction_shows_others/paris.md.yaml b/mre/mre_only_subtraction_shows_others/paris.md.yaml new file mode 100644 index 0000000..f6bf8fd --- /dev/null +++ b/mre/mre_only_subtraction_shows_others/paris.md.yaml @@ -0,0 +1,2 @@ +tags: +- france diff --git a/mre/mre_only_subtraction_shows_others/readme.md b/mre/mre_only_subtraction_shows_others/readme.md new file mode 100644 index 0000000..0e00132 --- /dev/null +++ b/mre/mre_only_subtraction_shows_others/readme.md @@ -0,0 +1,20 @@ +# Minimal Reproducible Example + +A search query with only subtraction should show all the elements in the +gallery minus the subtracted elements. + +## Reproduction steps + +1. Search for `-france`. + +## Expected result + +`berlin.md` should appear in the results. + +## Actual result + +The search yields no result at all. + +## Version info + +Bug present in ldgallery v2.2. diff --git a/mre/mre_similar_tags_caps/gallery.yaml b/mre/mre_similar_tags_caps/gallery.yaml new file mode 100644 index 0000000..8cbc96b --- /dev/null +++ b/mre/mre_similar_tags_caps/gallery.yaml @@ -0,0 +1,2 @@ +includedFiles: +- '*.md' diff --git a/mre/mre_similar_tags_caps/readme.md b/mre/mre_similar_tags_caps/readme.md new file mode 100644 index 0000000..1a00e52 --- /dev/null +++ b/mre/mre_similar_tags_caps/readme.md @@ -0,0 +1,49 @@ +# Minimal Reproducible Example + +Having two or more similar tags which differ only in their casing results in +the lowercase variant to be inserted instead of the other ones. + +## Reproduction steps + +1. Type `Test` in the tag input box and press enter. + +## Expected result + +The tag `Test` (starting with a capital letter) should be added to the search +query. + +## Actual result + +The tag `test` (starting with a lower case letter) is instead added to the +search query. + +## Version info + +Bug present in ldgallery v2.2. + +--- + +Having two or more similar tags which differ only in their casing results in +unrequested insertions in the query. + +## Reproduction steps + +1. Type `test` in the tag input box and press enter. +2. Press the enter key or click on the "Search" button, + one or multiple times! + +## Expected result + +It should just search for items with the `test` tag and display the result. + +## Actual result + +The tag `Test` is added to the input field even though it was never requested. +Trying to search again results in more instances of `test` and `Test` to be +added to the search field. + +No result is found because the resulting "forced" search query is wrong. + +## Version info + +Bug present in ldgallery v2.2. diff --git a/mre/mre_similar_tags_caps/test.md b/mre/mre_similar_tags_caps/test.md new file mode 100644 index 0000000..e69de29 diff --git a/mre/mre_similar_tags_caps/test.md.yaml b/mre/mre_similar_tags_caps/test.md.yaml new file mode 100644 index 0000000..997a5f6 --- /dev/null +++ b/mre/mre_similar_tags_caps/test.md.yaml @@ -0,0 +1,2 @@ +tags: +- test diff --git a/mre/mre_similar_tags_caps/test_with_caps.md b/mre/mre_similar_tags_caps/test_with_caps.md new file mode 100644 index 0000000..e69de29 diff --git a/mre/mre_similar_tags_caps/test_with_caps.md.yaml b/mre/mre_similar_tags_caps/test_with_caps.md.yaml new file mode 100644 index 0000000..a654d10 --- /dev/null +++ b/mre/mre_similar_tags_caps/test_with_caps.md.yaml @@ -0,0 +1,2 @@ +tags: +- Test diff --git a/mre/mre_tags_in_multiple_categories_not_correctly_filtered/baseball_bat.md b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/baseball_bat.md new file mode 100644 index 0000000..e69de29 diff --git a/mre/mre_tags_in_multiple_categories_not_correctly_filtered/baseball_bat.md.yaml b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/baseball_bat.md.yaml new file mode 100644 index 0000000..a340dd1 --- /dev/null +++ b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/baseball_bat.md.yaml @@ -0,0 +1,2 @@ +tags: +- object:bat diff --git a/mre/mre_tags_in_multiple_categories_not_correctly_filtered/cricket_bat.md b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/cricket_bat.md new file mode 100644 index 0000000..e69de29 diff --git a/mre/mre_tags_in_multiple_categories_not_correctly_filtered/cricket_bat.md.yaml b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/cricket_bat.md.yaml new file mode 100644 index 0000000..a340dd1 --- /dev/null +++ b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/cricket_bat.md.yaml @@ -0,0 +1,2 @@ +tags: +- object:bat diff --git a/mre/mre_tags_in_multiple_categories_not_correctly_filtered/gallery.yaml b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/gallery.yaml new file mode 100644 index 0000000..73103df --- /dev/null +++ b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/gallery.yaml @@ -0,0 +1,6 @@ +includedFiles: +- '*.md' + +tagCategories: +- animal +- object \ No newline at end of file diff --git a/mre/mre_tags_in_multiple_categories_not_correctly_filtered/readme.md b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/readme.md new file mode 100644 index 0000000..2f49aea --- /dev/null +++ b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/readme.md @@ -0,0 +1,105 @@ +# Minimal Reproducible Example + +Multiple issues are shown with this example. + +--- + +Incorrect related filters: + +Suggestions for related filters should only contain categories used in the +items in the search result, not all categories happening to contain tags in +the results which have the same name. + +## Reproduction steps + +1. Search for `animal`. + +## Expected result + +The related filters suggestions should only suggest `animal:bat`, but not +`object:bat`, since the only result does not have `object:bat`. + +## Actual result + +Both `animal:bat` and `object:bat` are suggested as related filters. +The latter is incorrect. + +## Version info + +Bug present in ldgallery v2.2. + +--- + +Incorrect related filters: + +Excluding a category should result in all tags in that category being excluded +from the related filters suggestions, even if they happen to contain a tag with +the same name. + +## Reproduction steps + +1. Search for `-animal`. + +## Expected result + +The `animal` category should not show up in the related filters suggestions. + +## Actual result + +The `animal` category still shows up in addition to the `object` category. + +## Version info + +Bug present in ldgallery v2.2. + +--- + +Incorrect search results and related filters: + +Excluding a category should only exclude tags in that category. +It should not exclude items having a tag with the same name in other +categories. + +## Reproduction steps + +1. Search for `-animal`. + +## Expected result + +`baseball_bat.md` and `cricket_bat.md` should appear in the search results, +because they do not have any tag in the category `animal`. + +## Actual result + +The search yields no result at all. +Strangely enough, the tag `bat` is still being suggested in both categories +in the related filters. + +## Version info + +Bug present in ldgallery v2.2. + +--- + +Incorrect search results: + +Excluding a tag within a category should only exclude tags in that category. +It should not exclude items having a tag with the same name in other +categories. + +## Reproduction steps + +1. Search for `-animal:bat`. + +## Expected result + +`baseball_bat.md` and `cricket_bat.md` should appear in the search results, +because they do not have that tag in the category `animal`, but `object`. + +## Actual result + +The search yields no result at all. + +## Version info + +Bug present in ldgallery v2.2. diff --git a/mre/mre_tags_in_multiple_categories_not_correctly_filtered/winged_bat.md b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/winged_bat.md new file mode 100644 index 0000000..e69de29 diff --git a/mre/mre_tags_in_multiple_categories_not_correctly_filtered/winged_bat.md.yaml b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/winged_bat.md.yaml new file mode 100644 index 0000000..04a6cc6 --- /dev/null +++ b/mre/mre_tags_in_multiple_categories_not_correctly_filtered/winged_bat.md.yaml @@ -0,0 +1,2 @@ +tags: +- animal:bat -- cgit v1.2.3 From fd5f97a5b688096ada9d34459bab42c417eec82b Mon Sep 17 00:00:00 2001 From: Zéro~Informatique Date: Sun, 26 Mar 2023 00:29:32 +0100 Subject: viewer: cannot scroll in text viewer GitHub: closes #360 --- viewer/src/views/item_handlers/PlainTextViewer.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/viewer/src/views/item_handlers/PlainTextViewer.vue b/viewer/src/views/item_handlers/PlainTextViewer.vue index 2ab429a..986e0ae 100644 --- a/viewer/src/views/item_handlers/PlainTextViewer.vue +++ b/viewer/src/views/item_handlers/PlainTextViewer.vue @@ -26,6 +26,7 @@ > 
     
@@ -63,7 +64,7 @@ const { isFinished, data } = useFetch(itemResourceUrl).text();
     border: none;
     white-space: pre-wrap;
     resize: horizontal; // Allow the user to adjust the width of the text view for easier column reading.
-    overflow: hidden; // Necessary for the resize handle to be shown in Chromium.
+    overflow-x: hidden !important; // Necessary for the resize handle to be shown in Chromium.
   }
 }
 
-- 
cgit v1.2.3


From 1f92cc4f17debdb6991a7f388f8e313d461744ff Mon Sep 17 00:00:00 2001
From: Zéro~Informatique
Date: Sun, 26 Mar 2023 18:14:13 +0200
Subject: viewer: cannot scroll in text viewer

- Horizontal resize is now available everywhere in LdGallery
- Increased slightly the PlainText font size for easier read
---
 viewer/src/views/MainLayout.vue                    |  8 ++++++
 viewer/src/views/item_handlers/PlainTextViewer.vue | 31 ++++++----------------
 2 files changed, 16 insertions(+), 23 deletions(-)

diff --git a/viewer/src/views/MainLayout.vue b/viewer/src/views/MainLayout.vue
index 30bfe97..5cac863 100644
--- a/viewer/src/views/MainLayout.vue
+++ b/viewer/src/views/MainLayout.vue
@@ -128,6 +128,14 @@ function validateSpashScreen() {
     left: var(--layout-left);
     z-index: 3;
     overflow-x: hidden;
+
+    // Forbid overflow when resizing.
+    // Necessary for the resize handle to be selectable on qutebrowser.
+    max-width: calc(100% - var(--layout-left) - $scrollbar-width);
+    margin: 0 auto; // Center
+    resize: horizontal;
+    // ---
+
     &:focus {
       outline: none;
     }
diff --git a/viewer/src/views/item_handlers/PlainTextViewer.vue b/viewer/src/views/item_handlers/PlainTextViewer.vue
index 986e0ae..71b5d15 100644
--- a/viewer/src/views/item_handlers/PlainTextViewer.vue
+++ b/viewer/src/views/item_handlers/PlainTextViewer.vue
@@ -19,18 +19,12 @@
 -->