From caf68fd92912f9ffc2291ba823cc194c1cc1c61a Mon Sep 17 00:00:00 2001 From: Zero~Informatique Date: Fri, 3 Apr 2020 05:43:07 +0200 Subject: viewer: items with long titles overflow GitHub: Resolves #137 --- viewer/src/components/LdThumbnail.vue | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'viewer/src/components/LdThumbnail.vue') diff --git a/viewer/src/components/LdThumbnail.vue b/viewer/src/components/LdThumbnail.vue index 3ef7fa8..5166834 100644 --- a/viewer/src/components/LdThumbnail.vue +++ b/viewer/src/components/LdThumbnail.vue @@ -29,7 +29,7 @@ />
- {{item.title}} + {{item.title | underscore-to-space}}
@@ -66,6 +66,8 @@ export default class LdThumbnail extends Vue { width: $thumbnail-other-size; height: $thumbnail-other-size; text-align: center; + word-break: break-all; + overflow: hidden; } .preload { -- cgit v1.2.3 From 44ada3fc6f092b9ee15de2f4ebbc269d4b354f64 Mon Sep 17 00:00:00 2001 From: Zero~Informatique Date: Sat, 4 Apr 2020 00:41:35 +0200 Subject: viewer: items with long titles overflow code review changes GitHub: Resolves #137 --- viewer/src/components/LdThumbnail.vue | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'viewer/src/components/LdThumbnail.vue') diff --git a/viewer/src/components/LdThumbnail.vue b/viewer/src/components/LdThumbnail.vue index 5166834..9805873 100644 --- a/viewer/src/components/LdThumbnail.vue +++ b/viewer/src/components/LdThumbnail.vue @@ -29,7 +29,7 @@ />
- {{item.title | underscore-to-space}} + {{item.title}}
@@ -65,8 +65,9 @@ export default class LdThumbnail extends Vue { .thumbnail-other { width: $thumbnail-other-size; height: $thumbnail-other-size; + padding-top: 1em; text-align: center; - word-break: break-all; + word-break: break-word; overflow: hidden; } -- cgit v1.2.3 From f391a682dbd725c1d8aba9c571472bd390bb6a8d Mon Sep 17 00:00:00 2001 From: Zero~Informatique Date: Sat, 4 Apr 2020 03:33:25 +0200 Subject: viewer: items with long titles overflow fixed line-height issue on filenames and icon heights GitHub: Resolves #137 --- viewer/src/components/LdThumbnail.vue | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'viewer/src/components/LdThumbnail.vue') diff --git a/viewer/src/components/LdThumbnail.vue b/viewer/src/components/LdThumbnail.vue index 9805873..f8343eb 100644 --- a/viewer/src/components/LdThumbnail.vue +++ b/viewer/src/components/LdThumbnail.vue @@ -28,7 +28,9 @@ @load="loading=false" />
- +
+ +
{{item.title}}
@@ -65,10 +67,13 @@ export default class LdThumbnail extends Vue { .thumbnail-other { width: $thumbnail-other-size; height: $thumbnail-other-size; - padding-top: 1em; + padding-top: $body-line-height * 2em; text-align: center; word-break: break-word; overflow: hidden; + > div { + min-height: $body-line-height * 3em; + } } .preload { -- cgit v1.2.3