From 6075916ef18dc4a8cbea41c941d2d0b519360262 Mon Sep 17 00:00:00 2001
From: Ananya Sen
Date: Tue, 26 Jun 2012 13:04:04 -0700
Subject: fixed code hinting and autocompletion bug

Signed-off-by: Ananya Sen <Ananya.Sen@motorola.com>
---
 .../ui/code-editor-view-options.reel/code-editor-view-options.css | 5 +++++
 .../code-editor-view-options.reel/code-editor-view-options.html   | 2 +-
 .../ui/code-editor-view-options.reel/code-editor-view-options.js  | 8 ++++++++
 3 files changed, 14 insertions(+), 1 deletion(-)

(limited to 'js/code-editor/ui')

diff --git a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.css b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.css
index aeaf604c..68d77f90 100644
--- a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.css
+++ b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.css
@@ -22,6 +22,11 @@
     vertical-align: middle;
 }
 
+.viewOptions .autoCodeComplete input{
+    width: 1em;
+    height: 1em;
+}
+
 .viewOptions .autoCodeComplete .disabled{
     color:#515151;
 }
diff --git a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.html b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.html
index 4448e1f1..3d5df256 100644
--- a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.html
+++ b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.html
@@ -54,7 +54,7 @@
         <input class="zoomFont" data-montage-id="zoomFont"/>
         <div class="autoCodeComplete" >
             <input type="checkbox" data-montage-id="codeComplete" />
-            <label data-montage-id="autoCompleteLabel">Automatic Completion</label>
+            <label data-montage-id="autoCompleteLabel">Auto Code Hints</label>
         </div>
         <div class="floatButtons">
             <!--<button disabled="disabled" id="format" value="format" class="nj-skinned format">Format</button>-->
diff --git a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js
index 13c9a705..04b509a6 100644
--- a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js
+++ b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js
@@ -121,6 +121,12 @@ exports.CodeEditorViewOptions = Montage.create(Component, {
               oneway : false
             });
 
+            Object.defineBinding(this.codeCompleteCheck , "checked", {
+              boundObject: this.application.ninja.codeEditorController,
+              boundObjectPropertyPath: "automaticCodeComplete",
+              oneway : false
+            });
+
         }
     },
 
@@ -137,6 +143,8 @@ exports.CodeEditorViewOptions = Montage.create(Component, {
             } else {
                 this.autoCompleteLabel.classList.remove("disabled");
             }
+
+            this.codeCompleteCheck.checked = false;
         }
     },
 
-- 
cgit v1.2.3


From 3391a8e6fd5df0d464edaffd98c2b3fde23acf5a Mon Sep 17 00:00:00 2001
From: Ananya Sen
Date: Tue, 26 Jun 2012 16:03:56 -0700
Subject: refactored to move bindings to template

Signed-off-by: Ananya Sen <Ananya.Sen@motorola.com>
---
 .../code-editor-view-options.css                   |  5 --
 .../code-editor-view-options.html                  |  8 ++-
 .../code-editor-view-options.js                    | 69 ++++++++++++++++------
 3 files changed, 56 insertions(+), 26 deletions(-)

(limited to 'js/code-editor/ui')

diff --git a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.css b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.css
index 68d77f90..aeaf604c 100644
--- a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.css
+++ b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.css
@@ -22,11 +22,6 @@
     vertical-align: middle;
 }
 
-.viewOptions .autoCodeComplete input{
-    width: 1em;
-    height: 1em;
-}
-
 .viewOptions .autoCodeComplete .disabled{
     color:#515151;
 }
diff --git a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.html b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.html
index 3d5df256..9871525b 100644
--- a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.html
+++ b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.html
@@ -11,12 +11,13 @@
     <script type="text/montage-serialization">
     {
         "codeCompleteCheck":{
-            "prototype": "montage/ui/input-checkbox.reel",
+            "prototype": "montage/ui/native/input-checkbox.reel",
             "properties": {
                 "element": {"#": "codeComplete"}
             },
             "bindings": {
-                "disabled": {"<-": "@owner.autocomplete"}
+                "disabled": {"<-": "@owner.autocomplete"},
+                "checked": {"<->": "@owner.automaticCodeHint"}
             }
         },
 
@@ -29,6 +30,9 @@
                 "stepSize" :10,
                 "acceptableUnits" : ["%"],
                 "units" : "%"
+            },
+            "bindings": {
+                "value": {"<->": "@owner.zoomFactor"}
             }
         },
 
diff --git a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js
index 04b509a6..6c983867 100644
--- a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js
+++ b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js
@@ -36,6 +36,21 @@ exports.CodeEditorViewOptions = Montage.create(Component, {
         }
     },
 
+    _codeEditorWrapper:{
+        value: null
+    },
+
+    codeEditorWrapper:{
+        get : function() {
+            return this._codeEditorWrapper;
+        },
+        set : function(value) {
+            if(this._codeEditorWrapper !== value){
+                this._codeEditorWrapper = value;
+            }
+        }
+    },
+
     _visible: {
         value: false
     },
@@ -97,6 +112,35 @@ exports.CodeEditorViewOptions = Montage.create(Component, {
         serializable: true
     },
 
+    _zoomFactor:{
+        value: 100
+    },
+
+    zoomFactor:{
+        get: function(){
+            return this._zoomFactor;
+        },
+        set: function(value){
+            this._zoomFactor = value;
+            if(this.codeEditorWrapper){this.codeEditorWrapper.handleZoom(value)};
+        }
+    },
+
+    _automaticCodeHint:{
+        value: false
+    },
+
+    automaticCodeHint:{
+        get: function(){
+            return this._automaticCodeHint;
+        },
+        set: function(value){
+            this._automaticCodeHint = value;
+            //additing additional meta properties on the editor
+            this._currentDocument.model.views.code.editor.automaticCodeHint = value;
+        }
+    },
+
     themeSelect: {
         value: null,
         serializable: true
@@ -114,19 +158,6 @@ exports.CodeEditorViewOptions = Montage.create(Component, {
             this.uncomment.addEventListener("click", this.handleUncomment.bind(this), false);
             this.themeSelect.addEventListener("change", this.handleThemeSelection.bind(this), false);
             this.shortKeys.addEventListener("click", this.handleShortKeys.bind(this), false);
-
-            Object.defineBinding(this.zoomHottext , "value", {
-              boundObject: this.application.ninja.codeEditorController,
-              boundObjectPropertyPath: "zoomFactor",
-              oneway : false
-            });
-
-            Object.defineBinding(this.codeCompleteCheck , "checked", {
-              boundObject: this.application.ninja.codeEditorController,
-              boundObjectPropertyPath: "automaticCodeComplete",
-              oneway : false
-            });
-
         }
     },
 
@@ -143,8 +174,6 @@ exports.CodeEditorViewOptions = Montage.create(Component, {
             } else {
                 this.autoCompleteLabel.classList.remove("disabled");
             }
-
-            this.codeCompleteCheck.checked = false;
         }
     },
 
@@ -163,20 +192,22 @@ exports.CodeEditorViewOptions = Montage.create(Component, {
 
     handleComment:{
         value: function(evt){
-            this.application.ninja.codeEditorController.commentSelection(true);
+            if(this.codeEditorWrapper){this.codeEditorWrapper.commentSelection(true)};
         }
     },
 
     handleUncomment:{
         value: function(evt){
-            this.application.ninja.codeEditorController.commentSelection(false);
+            if(this.codeEditorWrapper){this.codeEditorWrapper.commentSelection(false)};
         }
     },
 
     handleThemeSelection:{
         value: function(evt){
-            this.application.ninja.codeEditorController.editorTheme = this.themeSelect.options[this.themeSelect.selectedIndex].value;
-            this.application.ninja.codeEditorController.handleThemeSelection();
+            if(this.codeEditorWrapper){
+                this.codeEditorWrapper.editorTheme = this.themeSelect.options[this.themeSelect.selectedIndex].value;
+                this.codeEditorWrapper.handleThemeSelection();
+            }
         }
     },
 
-- 
cgit v1.2.3


From dd9c91e14708635dfaba2b31fd7f39938f719ab3 Mon Sep 17 00:00:00 2001
From: Ananya Sen
Date: Wed, 27 Jun 2012 10:29:35 -0700
Subject: initialize auto code hinting flag with checkbox value, on switching
 between documents

Signed-off-by: Ananya Sen <Ananya.Sen@motorola.com>
---
 .../ui/code-editor-view-options.reel/code-editor-view-options.js         | 1 +
 1 file changed, 1 insertion(+)

(limited to 'js/code-editor/ui')

diff --git a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js
index 6c983867..5a33909c 100644
--- a/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js
+++ b/js/code-editor/ui/code-editor-view-options.reel/code-editor-view-options.js
@@ -31,6 +31,7 @@ exports.CodeEditorViewOptions = Montage.create(Component, {
             } else {
                 this.visible = true;
                 this.autocomplete = !this.codeCompletionSupport[this._currentDocument.model.file.extension];
+                this._currentDocument.model.views.code.editor.automaticCodeHint = this.codeCompleteCheck.checked;
             }
 
         }
-- 
cgit v1.2.3