From cbb39c7833994c6e1db3f5b445fbedf5c70b95cc Mon Sep 17 00:00:00 2001 From: Ananya Sen Date: Tue, 3 Jul 2012 13:02:06 -0700 Subject: fixed IKNINJA-1877 : Clicking on a menu item should commit on mouse up and not on mouse down. Signed-off-by: Ananya Sen --- js/components/menu/menu-entry.reel/menu-entry.js | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) (limited to 'js/components/menu/menu-entry.reel') diff --git a/js/components/menu/menu-entry.reel/menu-entry.js b/js/components/menu/menu-entry.reel/menu-entry.js index 0f5503f6..93628dec 100755 --- a/js/components/menu/menu-entry.reel/menu-entry.js +++ b/js/components/menu/menu-entry.reel/menu-entry.js @@ -78,10 +78,21 @@ exports.MenuEntry = Montage.create(Component, { } }, + toggleOnMenuItemAction: { + value: function() { + // TODO: Hack! Rework this! + //for non menu headers only + this.parentComponent.ownerComponent.toggleActivation(this); + } + }, + captureMousedown: { value: function(event) { // TODO: Hack! Rework this! - this.parentComponent.ownerComponent.toggleActivation(this); + //for menu headers only + if(event.target.getAttribute("data-montage-id") === "topHeaderText"){ + this.parentComponent.ownerComponent.toggleActivation(this); + } } }, -- cgit v1.2.3 From 9461e7731f91dd03a15b0a62667e722a60c84721 Mon Sep 17 00:00:00 2001 From: Kris Kowal Date: Fri, 6 Jul 2012 12:44:57 -0700 Subject: Remove byte order markers (BOM) --- js/components/menu/menu-entry.reel/menu-entry.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/components/menu/menu-entry.reel') diff --git a/js/components/menu/menu-entry.reel/menu-entry.html b/js/components/menu/menu-entry.reel/menu-entry.html index 1b64c489..c15ed611 100755 --- a/js/components/menu/menu-entry.reel/menu-entry.html +++ b/js/components/menu/menu-entry.reel/menu-entry.html @@ -1,4 +1,4 @@ - +