From ac76f688b392f3c5959ec8d651ec35fe311c7a53 Mon Sep 17 00:00:00 2001
From: Eric Guzman
Date: Wed, 16 May 2012 14:12:14 -0700
Subject: Style Declaration - Fix update/add/addNew methods

---
 .../style-declaration.reel/style-declaration.js    | 48 ++++++++++++++++++----
 1 file changed, 41 insertions(+), 7 deletions(-)

(limited to 'js/panels/css-panel')

diff --git a/js/panels/css-panel/style-declaration.reel/style-declaration.js b/js/panels/css-panel/style-declaration.reel/style-declaration.js
index 33e77297..7ba00cc7 100644
--- a/js/panels/css-panel/style-declaration.reel/style-declaration.js
+++ b/js/panels/css-panel/style-declaration.reel/style-declaration.js
@@ -86,9 +86,9 @@ exports.StyleDeclaration = Montage.create(Component, {
 
             if(this.includeEmptyStyle) {
                 this.styles.push({
-                    "name": "property",
-                    "value" : "value",
-                    "isEmpty": true
+                    name    : "property",
+                    value   : "value",
+                    isEmpty : true
                 });
             }
 
@@ -159,6 +159,26 @@ exports.StyleDeclaration = Montage.create(Component, {
                     if(i) {
                         this.styles[i].value = this.declaration.getPropertyValue(prop);
                         usedIndices.push(i);
+                    } else {
+                        //// styles doesn't exist, does shorthand?
+                        var shorthands = ShorthandProps.CSS_SHORTHAND_MAP[prop],
+                            shorthandUpdated = false;
+
+                        if(shorthands) {
+                            shorthands.forEach(function(shorthand) {
+                                var shorthandIndex = styleToIndexMap[shorthand];
+                                if(shorthandIndex) {
+                                    //// if shorthand exists in list of rendered styles
+                                    //// update it
+                                    this.styles[shorthandIndex].value = this.declaration.getPropertyValue(shorthand);
+                                    shorthandUpdated = true;
+                                }
+                            }, this);
+                        }
+
+                        if(!shorthandUpdated) {
+                            this.addStyle(prop, this.declaration.getPropertyValue(prop));
+                        }
                     }
                 }, this);
 
@@ -179,13 +199,27 @@ exports.StyleDeclaration = Montage.create(Component, {
 
     addNewStyle : {
         value: function() {
-            this.styles.push({
-                "name": "property",
-                "value" : "value",
-                "isEmpty": true
+            this.addStyle('property', 'value', {
+                isEmpty : true
             });
         }
     },
+    addStyle : {
+        value: function(property, value, data) {
+            var styleDescriptor = {
+                property : property,
+                value : value
+            }, prop;
+
+            for(prop in data) {
+                if(data.hasOwnProperty(prop)) {
+                    styleDescriptor[prop] = data[prop];
+                }
+            }
+
+            this.arrayController.addObjects(styleDescriptor);
+        }
+    },
 
     /* drag/drop events */
     handleDrop : {
-- 
cgit v1.2.3