From d44f3196c925332dcaf45f7cf8c64e22a1994bb9 Mon Sep 17 00:00:00 2001 From: Nivesh Rajbhandari Date: Mon, 4 Jun 2012 17:11:06 -0700 Subject: Fill and Ink-Bottle fixes. Signed-off-by: Nivesh Rajbhandari --- js/tools/FillTool.js | 32 +++++++++++++++++++------------- 1 file changed, 19 insertions(+), 13 deletions(-) (limited to 'js/tools/FillTool.js') diff --git a/js/tools/FillTool.js b/js/tools/FillTool.js index 66dd9305..69807bc3 100755 --- a/js/tools/FillTool.js +++ b/js/tools/FillTool.js @@ -73,22 +73,28 @@ exports.FillTool = Montage.create(ModifierToolBase, { this.isDrawing = true; if(this._canColor && this.application.ninja.selectedElements.length) { + var fillInfo = {}, + color; + if(this.options.useFillColor.checked) { + fillInfo.colorInfo = {}; + color = this.options.fill; + if(color && color.color) + { + fillInfo.colorInfo.mode = color.colorMode; + fillInfo.colorInfo.color = color.color; + } else { + fillInfo.colorInfo.mode = "nocolor"; + fillInfo.colorInfo.color = null; + } + } - var color = this.options.fill, - colorInfo; - if(color && color.color) - { - colorInfo = { mode:color.colorMode, - color:color.color - }; + if(this.options.useWebGL.checked) { + fillInfo.webGLInfo = {}; + fillInfo.webGLInfo.material = this.options.fillMaterial.value; } - else - { - colorInfo = { mode:"nocolor", - color:color.color - }; + if(fillInfo.colorInfo || fillInfo.webGLInfo) { + ElementsMediator.setFill(this.application.ninja.selectedElements, fillInfo, "Change", "fillTool"); } - ElementsMediator.setColor(this.application.ninja.selectedElements, colorInfo, true, "Change", "fillTool"); } } } -- cgit v1.2.3 From e4e3ee77aa01f9b6e7592306ebfa9f123a60c624 Mon Sep 17 00:00:00 2001 From: Nivesh Rajbhandari Date: Wed, 6 Jun 2012 13:59:37 -0700 Subject: Do not create any tags or shapes with width or height of 0. Signed-off-by: Nivesh Rajbhandari --- js/tools/FillTool.js | 1 + 1 file changed, 1 insertion(+) (limited to 'js/tools/FillTool.js') diff --git a/js/tools/FillTool.js b/js/tools/FillTool.js index 69807bc3..e08ec1da 100755 --- a/js/tools/FillTool.js +++ b/js/tools/FillTool.js @@ -70,6 +70,7 @@ exports.FillTool = Montage.create(ModifierToolBase, { // Called by modifier tool base's HandleLeftButtonDown after updating selection (if needed) startDraw: { value: function(event) { + this.drawData = null; this.isDrawing = true; if(this._canColor && this.application.ninja.selectedElements.length) { -- cgit v1.2.3