From 8e2e04233a4bbb00cd780830769d5237f085dd02 Mon Sep 17 00:00:00 2001
From: pacien
Date: Tue, 8 Sep 2020 20:29:49 +0200
Subject: layout: mark config and password fields as unimportant for auto-fill

---
 ...configure_tools_dialog_encrypt_decrypt_keys.xml | 55 +++++++------
 .../configure_tools_dialog_network_generate.xml    | 55 +++++++------
 .../layout/configure_tools_dialog_network_join.xml | 93 +++++++++++-----------
 app/src/main/res/layout/dialog_decrypt_keys.xml    | 31 ++++----
 4 files changed, 122 insertions(+), 112 deletions(-)

(limited to 'app')

diff --git a/app/src/main/res/layout/configure_tools_dialog_encrypt_decrypt_keys.xml b/app/src/main/res/layout/configure_tools_dialog_encrypt_decrypt_keys.xml
index 1e8e64a..d21c4e6 100644
--- a/app/src/main/res/layout/configure_tools_dialog_encrypt_decrypt_keys.xml
+++ b/app/src/main/res/layout/configure_tools_dialog_encrypt_decrypt_keys.xml
@@ -2,7 +2,7 @@
 
 <!--
  * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
- * Copyright (C) 2017-2018 Pacien TRAN-GIRARD
+ * Copyright (C) 2017-2020 Pacien TRAN-GIRARD
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,33 +19,36 @@
 -->
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-							android:layout_width="match_parent"
-							android:layout_height="wrap_content"
-							android:orientation="vertical"
-							android:paddingBottom="@dimen/dialog_vertical_margin"
-							android:paddingLeft="@dimen/dialog_horizontal_margin"
-							android:paddingRight="@dimen/dialog_horizontal_margin"
-							android:paddingTop="@dimen/dialog_vertical_margin">
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:orientation="vertical"
+    android:paddingLeft="@dimen/dialog_horizontal_margin"
+    android:paddingTop="@dimen/dialog_vertical_margin"
+    android:paddingRight="@dimen/dialog_horizontal_margin"
+    android:paddingBottom="@dimen/dialog_vertical_margin">
 
-	<EditText
-		android:id="@+id/enc_dec_net_name"
-		android:layout_width="match_parent"
-		android:layout_height="wrap_content"
-		android:hint="@string/configure_tools_generate_config_net_name_hint"
-		android:inputType="text"/>
+    <EditText
+        android:id="@+id/enc_dec_net_name"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:hint="@string/configure_tools_generate_config_net_name_hint"
+        android:importantForAutofill="no"
+        android:inputType="text" />
 
-	<EditText
-		android:id="@+id/enc_dec_current_passphrase"
-		android:layout_width="match_parent"
-		android:layout_height="match_parent"
-		android:hint="@string/configure_tools_private_key_encryption_current_passphrase"
-		android:inputType="textVisiblePassword"/>
+    <EditText
+        android:id="@+id/enc_dec_current_passphrase"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:hint="@string/configure_tools_private_key_encryption_current_passphrase"
+        android:importantForAutofill="no"
+        android:inputType="textVisiblePassword" />
 
-	<EditText
-		android:id="@+id/enc_dec_new_passphrase"
-		android:layout_width="match_parent"
-		android:layout_height="match_parent"
-		android:hint="@string/configure_tools_private_key_encryption_new_passphrase"
-		android:inputType="textVisiblePassword"/>
+    <EditText
+        android:id="@+id/enc_dec_new_passphrase"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:hint="@string/configure_tools_private_key_encryption_new_passphrase"
+        android:importantForAutofill="no"
+        android:inputType="textVisiblePassword" />
 
 </LinearLayout>
diff --git a/app/src/main/res/layout/configure_tools_dialog_network_generate.xml b/app/src/main/res/layout/configure_tools_dialog_network_generate.xml
index 614cc16..a1c054a 100644
--- a/app/src/main/res/layout/configure_tools_dialog_network_generate.xml
+++ b/app/src/main/res/layout/configure_tools_dialog_network_generate.xml
@@ -2,7 +2,7 @@
 
 <!--
  * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
- * Copyright (C) 2017-2018 Pacien TRAN-GIRARD
+ * Copyright (C) 2017-2020 Pacien TRAN-GIRARD
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,33 +19,36 @@
 -->
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-							android:layout_width="match_parent"
-							android:layout_height="wrap_content"
-							android:orientation="vertical"
-							android:paddingBottom="@dimen/dialog_vertical_margin"
-							android:paddingLeft="@dimen/dialog_horizontal_margin"
-							android:paddingRight="@dimen/dialog_horizontal_margin"
-							android:paddingTop="@dimen/dialog_vertical_margin">
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:orientation="vertical"
+    android:paddingLeft="@dimen/dialog_horizontal_margin"
+    android:paddingTop="@dimen/dialog_vertical_margin"
+    android:paddingRight="@dimen/dialog_horizontal_margin"
+    android:paddingBottom="@dimen/dialog_vertical_margin">
 
-	<EditText
-		android:id="@+id/new_net_name"
-		android:layout_width="match_parent"
-		android:layout_height="match_parent"
-		android:hint="@string/configure_tools_generate_config_net_name_hint"
-		android:inputType="text"/>
+    <EditText
+        android:id="@+id/new_net_name"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:hint="@string/configure_tools_generate_config_net_name_hint"
+        android:importantForAutofill="no"
+        android:inputType="text" />
 
-	<EditText
-		android:id="@+id/new_node_name"
-		android:layout_width="match_parent"
-		android:layout_height="match_parent"
-		android:hint="@string/configure_tools_generate_config_node_name_hint"
-		android:inputType="text"/>
+    <EditText
+        android:id="@+id/new_node_name"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:hint="@string/configure_tools_generate_config_node_name_hint"
+        android:importantForAutofill="no"
+        android:inputType="text" />
 
-	<EditText
-		android:id="@+id/new_passphrase"
-		android:layout_width="match_parent"
-		android:layout_height="match_parent"
-		android:hint="@string/configure_tools_generate_config_optional_passphrase_hint"
-		android:inputType="textVisiblePassword"/>
+    <EditText
+        android:id="@+id/new_passphrase"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:hint="@string/configure_tools_generate_config_optional_passphrase_hint"
+        android:importantForAutofill="no"
+        android:inputType="textVisiblePassword" />
 
 </LinearLayout>
diff --git a/app/src/main/res/layout/configure_tools_dialog_network_join.xml b/app/src/main/res/layout/configure_tools_dialog_network_join.xml
index 9171284..f3672b3 100644
--- a/app/src/main/res/layout/configure_tools_dialog_network_join.xml
+++ b/app/src/main/res/layout/configure_tools_dialog_network_join.xml
@@ -2,7 +2,7 @@
 
 <!--
  * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
- * Copyright (C) 2017-2018 Pacien TRAN-GIRARD
+ * Copyright (C) 2017-2020 Pacien TRAN-GIRARD
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -20,59 +20,62 @@
 
 <layout xmlns:android="http://schemas.android.com/apk/res/android">
 
-	<data>
+    <data>
 
-		<variable
-			name="scanAction"
-			type="kotlin.jvm.functions.Function0&lt;kotlin.Unit>"/>
+        <variable
+            name="scanAction"
+            type="kotlin.jvm.functions.Function0&lt;kotlin.Unit>" />
 
-	</data>
+    </data>
 
-	<LinearLayout
-		android:layout_width="match_parent"
-		android:layout_height="wrap_content"
-		android:orientation="vertical"
-		android:paddingBottom="@dimen/dialog_vertical_margin"
-		android:paddingLeft="@dimen/dialog_horizontal_margin"
-		android:paddingRight="@dimen/dialog_horizontal_margin"
-		android:paddingTop="@dimen/dialog_vertical_margin">
+    <LinearLayout
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:orientation="vertical"
+        android:paddingLeft="@dimen/dialog_horizontal_margin"
+        android:paddingTop="@dimen/dialog_vertical_margin"
+        android:paddingRight="@dimen/dialog_horizontal_margin"
+        android:paddingBottom="@dimen/dialog_vertical_margin">
 
-		<EditText
-			android:id="@+id/net_name"
-			android:layout_width="match_parent"
-			android:layout_height="wrap_content"
-			android:hint="@string/configure_tools_generate_config_net_name_hint"
-			android:inputType="text"/>
+        <EditText
+            android:id="@+id/net_name"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:hint="@string/configure_tools_generate_config_net_name_hint"
+            android:importantForAutofill="no"
+            android:inputType="text" />
 
-		<LinearLayout
-			android:layout_width="match_parent"
-			android:layout_height="match_parent"
-			android:orientation="horizontal">
+        <LinearLayout
+            android:layout_width="match_parent"
+            android:layout_height="match_parent"
+            android:orientation="horizontal">
 
-			<EditText
-				android:id="@+id/invitation_url"
-				android:layout_width="0dp"
-				android:layout_height="wrap_content"
-				android:layout_weight="1"
-				android:hint="@string/configure_tools_join_network_field_invitation_url_hint"
-				android:inputType="textUri"/>
+            <EditText
+                android:id="@+id/invitation_url"
+                android:layout_width="0dp"
+                android:layout_height="wrap_content"
+                android:layout_weight="1"
+                android:hint="@string/configure_tools_join_network_field_invitation_url_hint"
+                android:importantForAutofill="no"
+                android:inputType="textUri" />
 
-			<ImageButton
-				android:layout_width="wrap_content"
-				android:layout_height="match_parent"
-				android:contentDescription="@string/configure_tools_join_network_action_scan_qr_code_action"
-				android:onClick="@{() -> scanAction.invoke()}"
-				android:src="@drawable/ic_photo_camera_primary_24dp"/>
+            <ImageButton
+                android:layout_width="wrap_content"
+                android:layout_height="match_parent"
+                android:contentDescription="@string/configure_tools_join_network_action_scan_qr_code_action"
+                android:onClick="@{() -> scanAction.invoke()}"
+                android:src="@drawable/ic_photo_camera_primary_24dp" />
 
-		</LinearLayout>
+        </LinearLayout>
 
-		<EditText
-			android:id="@+id/join_passphrase"
-			android:layout_width="match_parent"
-			android:layout_height="match_parent"
-			android:hint="@string/configure_tools_generate_config_optional_passphrase_hint"
-			android:inputType="textVisiblePassword"/>
+        <EditText
+            android:id="@+id/join_passphrase"
+            android:layout_width="match_parent"
+            android:layout_height="match_parent"
+            android:hint="@string/configure_tools_generate_config_optional_passphrase_hint"
+            android:importantForAutofill="no"
+            android:inputType="textVisiblePassword" />
 
-	</LinearLayout>
+    </LinearLayout>
 
 </layout>
diff --git a/app/src/main/res/layout/dialog_decrypt_keys.xml b/app/src/main/res/layout/dialog_decrypt_keys.xml
index a9b1e87..84c0367 100644
--- a/app/src/main/res/layout/dialog_decrypt_keys.xml
+++ b/app/src/main/res/layout/dialog_decrypt_keys.xml
@@ -2,7 +2,7 @@
 
 <!--
  * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
- * Copyright (C) 2017-2019 Pacien TRAN-GIRARD
+ * Copyright (C) 2017-2020 Pacien TRAN-GIRARD
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,20 +19,21 @@
 -->
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-							android:layout_width="match_parent"
-							android:layout_height="wrap_content"
-							android:orientation="vertical"
-							android:paddingLeft="@dimen/dialog_horizontal_margin"
-							android:paddingTop="@dimen/dialog_vertical_margin"
-							android:paddingRight="@dimen/dialog_horizontal_margin"
-							android:paddingBottom="@dimen/dialog_vertical_margin">
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:orientation="vertical"
+    android:paddingLeft="@dimen/dialog_horizontal_margin"
+    android:paddingTop="@dimen/dialog_vertical_margin"
+    android:paddingRight="@dimen/dialog_horizontal_margin"
+    android:paddingBottom="@dimen/dialog_vertical_margin">
 
-	<EditText
-		android:id="@+id/passphrase"
-		android:layout_width="match_parent"
-		android:layout_height="match_parent"
-		android:hint="@string/decrypt_key_modal_field_passphrase"
-		android:inputType="textPassword"
-		android:singleLine="true"/>
+    <EditText
+        android:id="@+id/passphrase"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:hint="@string/decrypt_key_modal_field_passphrase"
+        android:importantForAutofill="no"
+        android:inputType="textPassword"
+        android:singleLine="true" />
 
 </LinearLayout>
-- 
cgit v1.2.3