aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Guzman2012-05-16 14:14:25 -0700
committerEric Guzman2012-05-16 14:14:25 -0700
commitbbca3e05b39d43ce13c2f3e48cb33630ed7948b9 (patch)
treee58af8ca54b5ac21d42497986ff4ec3f4f2d1b33
parent73e98aef1ffa370c196c9c752d58dd4ed5f4faff (diff)
downloadninja-bbca3e05b39d43ce13c2f3e48cb33630ed7948b9.tar.gz
CSS Panel - Added flag to draw method to improve perceived loading time
-rw-r--r--js/panels/css-panel/rule-list-container.reel/rule-list-container.js12
-rw-r--r--js/panels/css-panel/rule-list.reel/rule-list.js3
-rw-r--r--js/panels/css-panel/style-declaration.reel/style-declaration.html3
-rw-r--r--js/panels/css-panel/styles-view-container.reel/styles-view-container.js3
4 files changed, 18 insertions, 3 deletions
diff --git a/js/panels/css-panel/rule-list-container.reel/rule-list-container.js b/js/panels/css-panel/rule-list-container.reel/rule-list-container.js
index 50d69093..4ee340e4 100644
--- a/js/panels/css-panel/rule-list-container.reel/rule-list-container.js
+++ b/js/panels/css-panel/rule-list-container.reel/rule-list-container.js
@@ -11,6 +11,7 @@ exports.RuleListContainer = Montage.create(Component, {
11 _instanceToAdd : { value: null }, 11 _instanceToAdd : { value: null },
12 _appendElement : { value: null }, 12 _appendElement : { value: null },
13 _lastDisplayedList : { value: null }, 13 _lastDisplayedList : { value: null },
14 ruleListDrawn : { value: null },
14 15
15 _displayedList : { value: null }, 16 _displayedList : { value: null },
16 displayedList : { 17 displayedList : {
@@ -157,5 +158,16 @@ exports.RuleListContainer = Montage.create(Component, {
157 } 158 }
158 } 159 }
159 } 160 }
161
162 },
163
164 didDraw: {
165 value: function() {
166 if(this.ruleListDrawn === true) {
167 var stylesView = this.parentComponent.parentComponent;
168 stylesView.needsDraw = stylesView.hasStyles = true;
169 }
170
171 }
160 } 172 }
161}); \ No newline at end of file 173}); \ No newline at end of file
diff --git a/js/panels/css-panel/rule-list.reel/rule-list.js b/js/panels/css-panel/rule-list.reel/rule-list.js
index bca298df..b7244a2c 100644
--- a/js/panels/css-panel/rule-list.reel/rule-list.js
+++ b/js/panels/css-panel/rule-list.reel/rule-list.js
@@ -184,6 +184,9 @@ exports.RuleList = Montage.create(Component, {
184 ///// Null out any rules that were just drawn 184 ///// Null out any rules that were just drawn
185 this.rulesToDraw.length = 0; 185 this.rulesToDraw.length = 0;
186 this.rulesToRemove.length = 0; 186 this.rulesToRemove.length = 0;
187
188 this.parentComponent.ruleListDrawn = true;
189 this.parentComponent.needsDraw = true;
187 } 190 }
188 } 191 }
189}); 192});
diff --git a/js/panels/css-panel/style-declaration.reel/style-declaration.html b/js/panels/css-panel/style-declaration.reel/style-declaration.html
index 2fdb11d5..f7415335 100644
--- a/js/panels/css-panel/style-declaration.reel/style-declaration.html
+++ b/js/panels/css-panel/style-declaration.reel/style-declaration.html
@@ -28,8 +28,7 @@ No rights, expressed or implied, whatsoever to this software are provided by Mot
28 "bindings": { 28 "bindings": {
29 "content": { 29 "content": {
30 "boundObject": {"@": "owner"}, 30 "boundObject": {"@": "owner"},
31 "boundObjectPropertyPath": "styles", 31 "boundObjectPropertyPath": "styles"
32 "oneway": true
33 } 32 }
34 } 33 }
35 }, 34 },
diff --git a/js/panels/css-panel/styles-view-container.reel/styles-view-container.js b/js/panels/css-panel/styles-view-container.reel/styles-view-container.js
index 1372de0c..e6e836ad 100644
--- a/js/panels/css-panel/styles-view-container.reel/styles-view-container.js
+++ b/js/panels/css-panel/styles-view-container.reel/styles-view-container.js
@@ -41,7 +41,8 @@ exports.StylesViewContainer = Montage.create(Component, {
41 }, 41 },
42 set: function(hasThem) { 42 set: function(hasThem) {
43 this._hasStyles = hasThem; 43 this._hasStyles = hasThem;
44 this.needsDraw = true; 44 //caller needs to set ndt
45 //this.needsDraw = true;
45 } 46 }
46 }, 47 },
47 48