aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValerio Virgillito2012-03-27 12:06:29 -0700
committerValerio Virgillito2012-03-27 12:06:29 -0700
commit675fffb08f570783f055471501f94fc273de2b9e (patch)
tree215b54eee4d6f982809087c59cf8f1d37b2f4350
parent73ae65902d355fcb75bcdb486eaa27c0d79125c8 (diff)
parent0a06e17da5759c29b63c32118c7f2b14452380b1 (diff)
downloadninja-675fffb08f570783f055471501f94fc273de2b9e.tar.gz
Merge pull request #146 from mqg734/WebGLFileIO
Fixes for Line Tool and EyeDropper tool runtime error.
-rwxr-xr-xjs/controllers/color-controller.js4
-rwxr-xr-xjs/controllers/elements/shapes-controller.js4
-rwxr-xr-xjs/tools/EyedropperTool.js9
3 files changed, 12 insertions, 5 deletions
diff --git a/js/controllers/color-controller.js b/js/controllers/color-controller.js
index 8e000b19..c6d664cf 100755
--- a/js/controllers/color-controller.js
+++ b/js/controllers/color-controller.js
@@ -227,14 +227,14 @@ exports.ColorController = Montage.create(Component, {
227 // 227 //
228 this.fill = color; 228 this.fill = color;
229 // 229 //
230 if(e._event.wasSetByCode && mode !== 'nocolor') return; 230 if(e._event.wasSetByCode) return;
231 // 231 //
232 this.setColor(mode, color, true); 232 this.setColor(mode, color, true);
233 } else if (input === 'stroke') { 233 } else if (input === 'stroke') {
234 // 234 //
235 this.stroke = color; 235 this.stroke = color;
236 // 236 //
237 if(e._event.wasSetByCode && mode !== 'nocolor') return; 237 if(e._event.wasSetByCode) return;
238 238
239 this.setColor(mode, color, false); 239 this.setColor(mode, color, false);
240 } 240 }
diff --git a/js/controllers/elements/shapes-controller.js b/js/controllers/elements/shapes-controller.js
index 5b9e4672..f0e9458b 100755
--- a/js/controllers/elements/shapes-controller.js
+++ b/js/controllers/elements/shapes-controller.js
@@ -274,6 +274,10 @@ exports.ShapesController = Montage.create(CanvasController, {
274 color = this.getShapeProperty(el, "stroke"); 274 color = this.getShapeProperty(el, "stroke");
275 } 275 }
276 276
277 if(!css) {
278 return null;
279 }
280
277 css = this.application.ninja.colorController.colorModel.webGlToCss(color); 281 css = this.application.ninja.colorController.colorModel.webGlToCss(color);
278 return this.application.ninja.colorController.getColorObjFromCss(css); 282 return this.application.ninja.colorController.getColorObjFromCss(css);
279 } 283 }
diff --git a/js/tools/EyedropperTool.js b/js/tools/EyedropperTool.js
index 7458a9e8..d627f03b 100755
--- a/js/tools/EyedropperTool.js
+++ b/js/tools/EyedropperTool.js
@@ -395,9 +395,12 @@ exports.EyedropperTool = Montage.create(toolBase, {
395 this._webGlWorld.importJSON(worldData); 395 this._webGlWorld.importJSON(worldData);
396 this._webGlWorld.render(); 396 this._webGlWorld.render();
397 setTimeout(function() { 397 setTimeout(function() {
398 this._webGlWorld.draw(); 398 if(this._webGlWorld)
399 this._imageDataContext.drawImage(this._webGlDataCanvas, 0, 0); 399 {
400 return this._getColorFromCanvas(this._imageDataContext, tmpPt, true); 400 this._webGlWorld.draw();
401 this._imageDataContext.drawImage(this._webGlDataCanvas, 0, 0);
402 return this._getColorFromCanvas(this._imageDataContext, tmpPt, true);
403 }
401 }.bind(this), 250); 404 }.bind(this), 250);
402 } 405 }
403 } 406 }