Fix for elements flying off into space when moving elements that overlap.

This was happening because our hit record's element and the browser's element from point did not match.

Signed-off-by: Nivesh Rajbhandari <mqg734@motorola.com>

2 files changed, 38 insertions, 1 deletions

diff --git a/js/helper-classes/3D/snap-manager.js b/js/helper-classes/3D/snap-manager.js
index 372be345..596ba56a 100755
--- a/js/helper-classes/3D/snap-manager.js
+++ b/js/helper-classes/3D/snap-manager.js
@@ -40,6 +40,7 @@ var SnapManager = exports.SnapManager = Montage.create(Component, {
 
         // keep a reference to the most recent hitRecord.  Used for drawing feedback on the stage
         _lastHit : { value: null, writable: true },
+        _hitRecords : { value: [], writable: true },
 
         // keep a list of objects to avoid snapping to
         _avoidList : { value: [], writable: true },
@@ -274,6 +275,11 @@ var SnapManager = exports.SnapManager = Montage.create(Component, {
                         }       //if (hitRecArray.length == 0)
 
                         var rtnHit;
+
+            // Save reference to hit records to verify last hit record's element matches browser's elementFromPoint
+            this._hitRecords.length = 0;
+            this._hitRecords = hitRecArray;
+
                         if (hitRecArray.length > 0)
                         {
                                 this.sortHitRecords( hitRecArray );
@@ -2246,6 +2252,30 @@ var SnapManager = exports.SnapManager = Montage.create(Component, {
                                 drawUtils.setDrawingSurfaceElement(saveContext);
                         }
                 }
-        }
+        },
+
+    findHitRecordForElement: {
+        value: function(elt) {
+            var rtnHit;
+
+            if (!this._hitRecords)  return;
+            var nHits = this._hitRecords.length;
+
+            for (var i=0;  i<nHits;  i++)
+            {
+                var hi = this._hitRecords[i];
+                if(hi.getElement() === elt)
+                {
+                    rtnHit = hi;
+                    break;
+                }
+            }
+            // catch-all to turn off drag plane snapping
+            this.deactivateDragPlane();
+
+            this.setLastHit( rtnHit );
+            return rtnHit;
+        }
+    }
 
 });
diff --git a/js/tools/modifier-tool-base.js b/js/tools/modifier-tool-base.js
index 7d946cb0..7892d015 100755
--- a/js/tools/modifier-tool-base.js
+++ b/js/tools/modifier-tool-base.js
@@ -133,6 +133,13 @@ exports.ModifierToolBase = Montage.create(DrawingTool, {
                                 // a snap on the mouse down
                                 var hitRec = snapManager.snap(point.x, point.y, do3DSnap);
 
+                // TODO - Check that hitRec's element matches element that browser says we clicked on
+                var elt = this.application.ninja.stage.GetElement(event);
+                if(elt !== hitRec.getElement())
+                {
+                    hitRec = snapManager.findHitRecordForElement(elt);
+                }
+
                 // we don't want to snap to selected objects during the drag
                 var len = this._targets.length;
                 for(var i=0; i<len; i++)