viewer: code update (no functional change)

Types { [x: T]: R } updated to Record<T, R>
Methods in template updated to getters (computed in VueJS), which are reactive and cached
Code formatting

14 files changed, 61 insertions, 53 deletions

diff --git a/viewer/src/@types/scrollposition.d.ts b/viewer/src/@types/scrollposition.d.ts
index b2147fa..cd393b3 100644
--- a/viewer/src/@types/scrollposition.d.ts
+++ b/viewer/src/@types/scrollposition.d.ts
@@ -17,4 +17,4 @@
 -- along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
-type ScrollPosition = { [index: string]: number }
+type ScrollPosition = Record<string, number>
diff --git a/viewer/src/@types/tag.d.ts b/viewer/src/@types/tag.d.ts
index 76f1207..59ae779 100644
--- a/viewer/src/@types/tag.d.ts
+++ b/viewer/src/@types/tag.d.ts
@@ -31,8 +31,8 @@ declare namespace Tag {
     operation: string; // Enum Operation
     display: string;
   }
-  type SearchByOperation = { [index: string]: Tag.Search[] };
-  type Index = { [index: string]: Node };
+  type SearchByOperation = Record<string, Tag.Search[]>;
+  type Index = Record<string, Node>;
 
   interface Category {
     tag: string;
diff --git a/viewer/src/components/LdAudioViewer.vue b/viewer/src/components/LdAudioViewer.vue
index d115a34..739d36a 100644
--- a/viewer/src/components/LdAudioViewer.vue
+++ b/viewer/src/components/LdAudioViewer.vue
@@ -21,10 +21,11 @@
 <template>
   <div class="flex-column container-vh-centering">
     <ld-thumbnail :item="audioItem" />
-    <audio :class="$style.player" :src="itemResourceUrl()" preload="auto" controls>
-      <a :download="itemFileName()" :href="itemResourceUrl()">
-        {{ $t("download.download-file-fmt", [itemFileName()]) }}
-      </a>
+    <audio :class="$style.player" :src="itemResourceUrl" preload="auto" controls>
+      <a
+        :download="itemFileName"
+        :href="itemResourceUrl"
+      >{{ $t("download.download-file-fmt", [itemFileName]) }}</a>
     </audio>
   </div>
 </template>
@@ -33,14 +34,15 @@
 import { Component, Prop, Vue } from "vue-property-decorator";
 import Navigation from "@/services/navigation";
 
-@Component export default class LdAudioViewer extends Vue {
+@Component
+export default class LdAudioViewer extends Vue {
   @Prop({ required: true }) readonly audioItem!: Gallery.Audio;
 
-  itemResourceUrl(): string {
+  get itemResourceUrl(): string {
     return this.$galleryStore.resourceRoot + this.audioItem.properties.resource;
   }
 
-  itemFileName(): string {
+  get itemFileName(): string {
     return Navigation.getFileName(this.audioItem);
   }
 }
diff --git a/viewer/src/components/LdCommand.vue b/viewer/src/components/LdCommand.vue
index d961519..49d86bb 100644
--- a/viewer/src/components/LdCommand.vue
+++ b/viewer/src/components/LdCommand.vue
@@ -21,17 +21,17 @@
 <template>
   <div class="flex command-btns">
     <a class="link" :title="$t('command.search')" @click="$uiStore.toggleFullWidth()">
-      <fa-icon :icon="commandToggleSearchPanelIcon()" size="lg" />
+      <fa-icon :icon="commandToggleSearchPanelIcon" size="lg" />
     </a>
     <a
-      :class="{'disabled': isEntryPoint()}"
+      :class="{'disabled': isEntryPoint}"
       class="link command-secondary"
       :title="$t('command.back')"
-      @click="isEntryPoint() || $router.back()"
+      @click="isEntryPoint || $router.back()"
     >
       <fa-icon icon="arrow-left" size="lg" />
     </a>
-    <router-link :class="{'disabled': isRoot()}" :title="$t('command.parent')" :to="parent()">
+    <router-link :class="{'disabled': isRoot}" :title="$t('command.parent')" :to="parent">
       <fa-icon icon="folder" size="xs" />
       <fa-icon icon="level-up-alt" size="lg" />
     </router-link>
@@ -46,19 +46,19 @@ import { RawLocation } from "vue-router";
 export default class LdCommand extends Vue {
   @Prop({ type: Array, required: true }) readonly currentItemPath!: Gallery.Item[];
 
-  commandToggleSearchPanelIcon(): string {
+  get commandToggleSearchPanelIcon(): string {
     return this.$uiStore.fullWidth ? "search" : "angle-double-left";
   }
 
-  isRoot(): boolean {
+  get isRoot(): boolean {
     return this.currentItemPath.length <= 1 && !this.$uiStore.searchMode;
   }
 
-  isEntryPoint(): boolean {
+  get isEntryPoint(): boolean {
     return history.state?.ldgallery === "ENTRYPOINT"; // Set by MainLayout.vue
   }
 
-  parent(): RawLocation {
+  get parent(): RawLocation {
     if (this.$uiStore.searchMode) return this.$route.path;
     if (this.currentItemPath.length > 1) return this.currentItemPath[this.currentItemPath.length - 2];
     return "";
diff --git a/viewer/src/components/LdDownload.vue b/viewer/src/components/LdDownload.vue
index d7dfb7d..7b09dab 100644
--- a/viewer/src/components/LdDownload.vue
+++ b/viewer/src/components/LdDownload.vue
@@ -20,10 +20,10 @@
 
 <template>
   <div class="container-vh-centering">
-    <a :class="$style.content" :download="itemFileName()" :href="itemDownloadUrl()">
+    <a :class="$style.content" :download="itemFileName" :href="itemDownloadUrl">
       <!-- TODO: show thumbnail instead of this generic file download icon? -->
       <fa-icon :class="$style.icon" icon="file-download" size="6x" />
-      <div>{{ $t("download.download-file-fmt", [itemFileName()]) }}</div>
+      <div>{{ $t("download.download-file-fmt", [itemFileName]) }}</div>
     </a>
   </div>
 </template>
@@ -32,14 +32,15 @@
 import { Component, Prop, Vue } from "vue-property-decorator";
 import Navigation from "@/services/navigation";
 
-@Component export default class LdDownload extends Vue {
+@Component
+export default class LdDownload extends Vue {
   @Prop({ required: true }) readonly item!: Gallery.Other;
 
-  itemFileName(): string {
+  get itemFileName(): string {
     return Navigation.getFileName(this.item);
   }
 
-  itemDownloadUrl(): string {
+  get itemDownloadUrl(): string {
     return this.$galleryStore.resourceRoot + this.item.properties.resource;
   }
 }
diff --git a/viewer/src/components/LdGallery.vue b/viewer/src/components/LdGallery.vue
index e512758..5a72d99 100644
--- a/viewer/src/components/LdGallery.vue
+++ b/viewer/src/components/LdGallery.vue
@@ -18,7 +18,7 @@
 -->
 
 <template>
-  <ld-error v-if="hasNoResults()" icon="search" :message="noresult" />
+  <ld-error v-if="hasNoResults" icon="search" :message="noresult" />
   <div v-else class="thumbnail-tiles">
     <router-link v-for="item in items" :key="item.path" :to="item.path">
       <ld-thumbnail :item="item" />
@@ -35,7 +35,7 @@ export default class LdPicture extends Vue {
   @Prop({ type: Array, required: true }) readonly items!: Gallery.Item[];
   @Prop(String) readonly noresult?: string;
 
-  hasNoResults(): boolean {
+  get hasNoResults(): boolean {
     return Boolean(this.noresult) && this.items.length === 0;
   }
 }
diff --git a/viewer/src/components/LdPdfViewer.vue b/viewer/src/components/LdPdfViewer.vue
index 20055cc..b1f6c64 100644
--- a/viewer/src/components/LdPdfViewer.vue
+++ b/viewer/src/components/LdPdfViewer.vue
@@ -22,7 +22,7 @@
   <!-- intermediate container necessary to eliminate the double scrollbar -->
   <div class="fill no-scroll">
     <!-- prefer native browser PDF viewer if available -->
-    <object class="fill" :data="itemResourceUrl()" type="application/pdf">
+    <object class="fill" :data="itemResourceUrl" type="application/pdf">