diff options
author | Nivesh Rajbhandari | 2012-07-19 13:37:04 -0700 |
---|---|---|
committer | Nivesh Rajbhandari | 2012-07-19 13:37:04 -0700 |
commit | 71795a786342b3d84ef904dc448b4ce840a44810 (patch) | |
tree | 26fb676e48bf6d1a64c638362868b3aff1e5f68a /js/tools | |
parent | 1fde3bdcaeec81702d58e95607076603d61f946e (diff) | |
download | ninja-71795a786342b3d84ef904dc448b4ce840a44810.tar.gz |
IKNINJA-1924 - Hovering over panel resizers after collapsing and expanding panel causes error.
Canvas sizes were not updated when using the splitter to toggle collapse/expansion of panels. This was fixed by the StageDrawingFixes pull request. We should also guard agains null value in stage's getElement routine.
Signed-off-by: Nivesh Rajbhandari <mqg734@motorola.com>
Diffstat (limited to 'js/tools')
-rwxr-xr-x | js/tools/ShapeTool.js | 34 |
1 files changed, 0 insertions, 34 deletions
diff --git a/js/tools/ShapeTool.js b/js/tools/ShapeTool.js index 26ed9c6f..ecc0dca3 100755 --- a/js/tools/ShapeTool.js +++ b/js/tools/ShapeTool.js | |||
@@ -70,7 +70,6 @@ exports.ShapeTool = Montage.create(DrawingTool, { | |||
70 | this.doDraw(event); | 70 | this.doDraw(event); |
71 | } else { | 71 | } else { |
72 | this.doSnap(event); | 72 | this.doSnap(event); |
73 | this._showFeedbackOnMouseMove(event); | ||
74 | } | 73 | } |
75 | 74 | ||
76 | this.drawLastSnap(); // Required cleanup for both Draw/Feedbacks | 75 | this.drawLastSnap(); // Required cleanup for both Draw/Feedbacks |
@@ -159,39 +158,6 @@ exports.ShapeTool = Montage.create(DrawingTool, { | |||
159 | } | 158 | } |
160 | }, | 159 | }, |
161 | 160 | ||
162 | /** Show a border when mousing | ||
163 | * over existing canvas elements to signal to the user that | ||
164 | * the drawing operation will act on the targeted canvas. | ||
165 | **/ | ||
166 | _showFeedbackOnMouseMove: { | ||
167 | value: function (event) { | ||
168 | // TODO - This call is causing the canvas to redraw 3 times per mouse move | ||
169 | var targetedObject = this.application.ninja.stage.getElement(event, true); | ||
170 | |||
171 | if (targetedObject) { | ||
172 | if((targetedObject.nodeName === "CANVAS") && !ShapesController.isElementAShape(targetedObject)) | ||
173 | { | ||
174 | if (targetedObject !== this._targetedElement) { | ||
175 | if(this._targetedElement) | ||
176 | { | ||
177 | this._targetedElement.classList.remove("active-element-outline"); | ||
178 | } | ||
179 | this._targetedElement = targetedObject; | ||
180 | this._targetedElement.classList.add("active-element-outline"); | ||
181 | } | ||
182 | } | ||
183 | else if (this._targetedElement) { | ||
184 | this._targetedElement.classList.remove("active-element-outline"); | ||
185 | this._targetedElement = null; | ||
186 | } | ||
187 | } | ||
188 | else if (this._targetedElement) { | ||
189 | this._targetedElement.classList.remove("elem-red-outline"); | ||
190 | this._targetedElement = null; | ||
191 | } | ||
192 | } | ||
193 | }, | ||
194 | |||
195 | RenderShape: | 161 | RenderShape: |
196 | { | 162 | { |
197 | value: function (w, h, planeMat, midPt) | 163 | value: function (w, h, planeMat, midPt) |