storage: remove embedded FTP server

Moving back the configuration files and logs to the user-accessible
storage. Everything should be accessible through a file manager using
the "USB storage" mode. The embedded FTP server is no longer
necessary.

3 files changed, 0 insertions, 294 deletions

diff --git a/app/src/main/java/org/pacien/tincapp/activities/configure/ConfigurationAccessServerFragment.kt b/app/src/main/java/org/pacien/tincapp/activities/configure/ConfigurationAccessServerFragment.kt
deleted file mode 100644
index c90299a..0000000
--- a/app/src/main/java/org/pacien/tincapp/activities/configure/ConfigurationAccessServerFragment.kt
+++ /dev/null
@@ -1,77 +0,0 @@
-/*
- * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
- * Copyright (C) 2017-2020 Pacien TRAN-GIRARD
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <https://www.gnu.org/licenses/>.
- */
-
-package org.pacien.tincapp.activities.configure
-
-import android.content.Intent
-import android.os.Bundle
-import android.view.LayoutInflater
-import android.view.View
-import android.view.ViewGroup
-import androidx.databinding.Observable
-import androidx.databinding.ObservableBoolean
-import org.pacien.tincapp.activities.BaseFragment
-import org.pacien.tincapp.databinding.ConfigureToolsConfigurationAccessFragmentBinding
-import org.pacien.tincapp.service.ConfigurationAccessService
-
-/**
- * @author pacien
- */
-class ConfigurationAccessServerFragment : BaseFragment() {
-  private val ftpServerStartListener = object : Observable.OnPropertyChangedCallback() {
-    override fun onPropertyChanged(sender: Observable, propertyId: Int) {
-      binding.ftpEnabled = (sender as ObservableBoolean).get()
-    }
-  }
-
-  private lateinit var binding: ConfigureToolsConfigurationAccessFragmentBinding
-
-  override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
-    binding = ConfigureToolsConfigurationAccessFragmentBinding.inflate(inflater, container, false)
-    binding.toggleFtpState = { toggleServer() }
-    setConnectionInfo()
-    return binding.root
-  }
-
-  override fun onResume() {
-    super.onResume()
-    setConnectionInfo()
-    ConfigurationAccessService.runningState.addOnPropertyChangedCallback(ftpServerStartListener)
-    binding.ftpEnabled = ConfigurationAccessService.runningState.get()
-  }
-
-  override fun onPause() {
-    ConfigurationAccessService.runningState.removeOnPropertyChangedCallback(ftpServerStartListener)
-    super.onPause()
-  }
-
-  private fun setConnectionInfo() {
-    binding.ftpUsername = ConfigurationAccessService.getFtpUsername()
-    binding.ftpPassword = ConfigurationAccessService.getFtpPassword()
-    binding.ftpPort = ConfigurationAccessService.getFtpPort()
-  }
-
-  private fun toggleServer() {
-    val targetServiceIntent = Intent(requireContext(), ConfigurationAccessService::class.java)
-
-    if (binding.ftpEnabled)
-      requireContext().stopService(targetServiceIntent)
-    else
-      requireContext().startService(targetServiceIntent)
-  }
-}
diff --git a/app/src/main/java/org/pacien/tincapp/context/AppNotificationManager.kt b/app/src/main/java/org/pacien/tincapp/context/AppNotificationManager.kt
index 5b01a54..d6e21f5 100644
--- a/app/src/main/java/org/pacien/tincapp/context/AppNotificationManager.kt
+++ b/app/src/main/java/org/pacien/tincapp/context/AppNotificationManager.kt
@@ -36,10 +36,7 @@ import org.pacien.tincapp.utils.PendingIntentUtils
 class AppNotificationManager(private val context: Context) {
   companion object {
     private const val ERROR_CHANNEL_ID = "org.pacien.tincapp.notification.channels.error"
-    private const val CONFIG_ACCESS_CHANNEL_ID = "org.pacien.tincapp.notification.channels.configuration"
-
     const val ERROR_NOTIFICATION_ID = 0
-    const val CONFIG_ACCESS_NOTIFICATION_ID = 1
   }
 
   init {
@@ -65,9 +62,6 @@ class AppNotificationManager(private val context: Context) {
     NotificationManagerCompat.from(context).cancelAll()
   }
 
-  fun newConfigurationAccessNotificationBuilder() =
-    NotificationCompat.Builder(context, CONFIG_ACCESS_CHANNEL_ID)
-
   @RequiresApi(Build.VERSION_CODES.O)
   private fun registerChannels() {
     context.getSystemService(NotificationManager::class.java)
@@ -78,13 +72,6 @@ class AppNotificationManager(private val context: Context) {
           NotificationManager.IMPORTANCE_HIGH
         ))
       }
-      .apply {
-        createNotificationChannel(NotificationChannel(
-          CONFIG_ACCESS_CHANNEL_ID,
-          context.getString(R.string.notification_config_access_channel_name),
-          NotificationManager.IMPORTANCE_MIN
-        ))
-      }
   }
 
   private fun NotificationCompat.Builder.setHighPriority() = apply {
diff --git a/app/src/main/java/org/pacien/tincapp/service/ConfigurationAccessService.kt b/app/src/main/java/org/pacien/tincapp/service/ConfigurationAccessService.kt
deleted file mode 100644
index 916f19d..0000000
--- a/app/src/main/java/org/pacien/tincapp/service/ConfigurationAccessService.kt
+++ /dev/null
@@ -1,204 +0,0 @@
-/*
- * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
- * Copyright (C) 2017-2023 Pacien TRAN-GIRARD
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <https://www.gnu.org/licenses/>.
- */
-
-package org.pacien.tincapp.service
-
-import android.app.Service
-import android.content.Context
-import android.content.Intent
-import android.os.IBinder
-import androidx.databinding.ObservableBoolean
-import ch.qos.logback.classic.Level
-import ch.qos.logback.classic.Logger
-import org.apache.ftpserver.ConnectionConfigFactory
-import org.apache.ftpserver.DataConnectionConfigurationFactory
-import org.apache.ftpserver.FtpServer
-import org.apache.ftpserver.FtpServerFactory
-import org.apache.ftpserver.ftplet.*
-import org.apache.ftpserver.listener.ListenerFactory
-import org.apache.ftpserver.usermanager.UsernamePasswordAuthentication
-import org.apache.ftpserver.usermanager.impl.WritePermission
-import org.pacien.tincapp.R
-import org.pacien.tincapp.activities.configure.ConfigureActivity
-import org.pacien.tincapp.context.App
-import org.pacien.tincapp.context.AppNotificationManager
-import org.pacien.tincapp.extensions.Java.defaultMessage
-import org.pacien.tincapp.utils.PendingIntentUtils
-import org.slf4j.LoggerFactory
-import java.io.IOException
-
-/**
- * FTP server service allowing a remote and local user to access and modify configuration files in
- * the application's context.
- *
- * @author pacien
- */
-class ConfigurationAccessService : Service() {
-  companion object {
-    // Apache Mina FtpServer's INFO log level is actually VERBOSE.
-    // The object holds static references to those loggers so that they stay around.
-    @Suppress("unused")
-    private val MINA_FTP_LOGGER_OVERRIDER = MinaLoggerOverrider(Level.WARN)
-
-    private val context by lazy { App.getContext() }
-    private val store by lazy { context.getSharedPreferences("${this::class.java.`package`!!.name}.ftp", Context.MODE_PRIVATE)!! }
-    val runningState = ObservableBoolean(false)